Conversation
…apphosting, and runfunctions (b/568084751)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes three unused experiments ('crossservicerules', 'emulatorapphosting', and 'runfunctions') from 'src/experiments.ts' and documents these removals in 'CHANGELOG.md'. There are no review comments, so I have no feedback to provide.
…task-remove-unreferenced-experiment # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/568084751
Proposed Improvement
Removes three dead and unreferenced experiment entries from
ALL_EXPERIMENTSinsrc/experiments.ts:runfunctionsemulatorapphostingcrossservicerulesNone of these experiments are referenced anywhere else in the codebase or checked via
isEnabled/assertEnabled. Existing user preferences for unknown experiments are dropped gracefully bylocalPreferences()andenableExperimentsFromCliEnvVariable().Verification
npm run build: clean buildnpm run lint:quiet: full-repo lint passed cleanly (0 errors)npm run test:compile: passed cleanlynpx mocha src/experiments.spec.ts: passed cleanlynode lib/bin/firebase.js experiments:enable crossservicerulescorrectly fails with unknown experiment error