Conversation
…t, universal-analytics, and @apphosting/common (b/568084099)
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes unused dependencies from package.json, including @apphosting/common, proxy-agent, and universal-analytics (along with its types and overrides), and updates CHANGELOG.md accordingly. As there are no review comments, I have no additional feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/568084099
Proposed Improvement
Removed unused production dependencies
proxy-agent,universal-analytics, and@apphosting/common, along with@types/universal-analyticsfrom devDependencies and theuniversal-analyticsuuid override block frompackage.json. Regeneratednpm-shrinkwrap.jsonusing pinnednpm@11.9, cleanly removing ~40 unused transitive packages from the published package dependency tree.Verification
npm ci: Installed clean lockfile successfully.npm run build: TypeScript compilation and build steps succeeded.npm run lint:quiet: Passed cleanly across the entire repository (ESLint and Prettier).npm run test:compile: Passed cleanly.npx mocha src/apiv2.spec.ts src/track.spec.ts: All 54 tests passed.npx -y npm@11.9 install --package-lock-only --ignore-scriptsproduces no diff againstnpm-shrinkwrap.json.