Conversation
ssakhamu
commented
Oct 1, 2026
ssakhamu
commented
- creates file for sending requests to cloudtrace and provisionTraceStorage call w/tests
- adds call to crashlytics onboarding w/ updated tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Cloud Trace integration to the Crashlytics onboarding process by enabling the Cloud Trace API and provisioning trace storage via a dummy span write. Feedback suggests refactoring the static traceClient instantiation into a dynamic helper function to correctly respect environment variable overrides, and utilizing the getError utility to safely wrap caught errors when throwing a FirebaseError.
ff31496 to
d9376b8
Compare
f428142 to
ea12d67
Compare
| "crashlytics", | ||
| false, | ||
| ); | ||
| expect(ensureStub).to.not.have.been.calledWith( |
There was a problem hiding this comment.
should this test just be to.not.have.been.called ?
There was a problem hiding this comment.
esnureStub is called twice with different parameters above so this is to make sure it doesn't get called with these parameters. Otherwise, it would fail as it is called twice.
This branch has not been deployed
3 participants
