Skip to content

fix(remote_config,web): suppress deprecated_member_use on Map.unmodifiable - #18635

Draft
russellwheatley wants to merge 1 commit into
mainfrom
fix/remote-config-web-deprecated-map-unmodifiable
Draft

fix(remote_config,web): suppress deprecated_member_use on Map.unmodifiable#18635
russellwheatley wants to merge 1 commit into
mainfrom
fix/remote-config-web-deprecated-map-unmodifiable

Conversation

@russellwheatley

Copy link
Copy Markdown
Member

dart:core's Map.unmodifiable() is now @Deprecated("Use Map.unmodifiableOf instead"), but Map.unmodifiableOf needs Dart 3.13.0, which is above this package's SDK floor (see #18634 for the separate discussion on where that floor should sit).

Suppressing the warning here rather than migrating, since raising the floor to 3.13.0 (released weeks ago) just for this one call isn't worth it.

…iable

dart:core deprecated Map.unmodifiable() in favor of Map.unmodifiableOf(),
but the latter needs Dart 3.13.0, above this package's current SDK floor.
Suppress the warning rather than raise the floor for one call site.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant