[AI] Improve App Check Instructions#1859
Conversation
paulb777
requested review from
andrewheard,
daymxn,
ncooke3,
peterfriese and
rachelsaunders
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates Firebase App Check into the iOS example application using the AppCheckDebugProviderFactory for local development, and updates the README with detailed instructions on configuring debug tokens. Feedback was provided to wrap the debug provider configuration in a #if DEBUG preprocessor block to prevent it from being active in production builds, which poses a security risk.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request integrates Firebase App Check into the FirebaseAIExample app, configuring the debug provider for development environments and updating the README with instructions on how to use it. However, the import of FirebaseAppCheck will cause a compilation error because the dependency has not been added to the Xcode project target.
|
@ncooke3 Thanks for the thorough review and improvement suggestions! |
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
|
Going to merge here. Let's address any subsequent comments in other PRs. |
4 participants
No description provided.