Restore English API identifiers in localized pages - #1419
Merged
Merged
Conversation
The CI check "Locale literals and extraction-hostile markdown" fails on clean main. Its first step, scripts/check-locale-api-literals.sh, reports 14 translated API identifiers in es/, fr/ and pt-BR/. Every open pull request inherits the failure. PR #1393 added the check and restored the English identifiers. PR #1406 restored them again after the locadex sync in #1394 overwrote them. The locadex syncs in #1411 and #1413 reintroduced them. This commit restores changeTracking, crawl.started and scrapedData on the 14 flagged pages. It repeats the .mdx hunks of #1406. Only the identifier strings change. All three docs checks now exit 0. The translation memory still holds the translated strings. The next locadex sync will reintroduce them unless the terms are pinned as do-not-translate in the General Translation dashboard. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gT8R64Yuvq8jQszkLdtQo
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
The check scans only .mdx files, so it cannot see this description. The string is the same identifier and the same translation-memory bug as the 14 pages. PR #1406 fixed it too. A partial revert would read as a deliberate choice to leave this file translated. Only the identifier changes. The description keeps its Portuguese prose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gT8R64Yuvq8jQszkLdtQo
Chadha93
marked this pull request as ready for review
September 15, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Gaurav Chadha · Slack thread
Before: The check "Locale literals and extraction-hostile markdown" is red. Its first step,
sh scripts/check-locale-api-literals.sh, reports 14 translated API identifiers ines/,fr/andpt-BR/. The check fails on cleanmain(37e7a17), so every open pull request inherits the failure. Readers of those pages see format names and webhook event names the API rejects, such asseguimientoDeCambios,suiviDesModifications,rastreioDeMudanças,rastreo.iniciadoanddadosRaspados.After: The 14 pages use the English identifiers again:
changeTracking,crawl.startedandscrapedData. The check is green on this pull request. CI stops at the first failing step, socheck-locale-api-literals-selftest.shandcheck-extraction-hostile-markdown.shnever ran on a red base. Both now run and pass in CI as well.How: this repeats the
.mdxhunks of #1406. In code samples and inline code the identifier goes back to English. In prose the identifier becomes normal translated prose ("seguimiento de cambios", "suivi des modifications", "rastreamento de mudanças"), which is what the surrounding sentence needs. The check script is not changed, weakened or skipped. Only the flagged identifier strings change: no reformatting and no retranslation.pt-BR/api-reference/v1-openapi.jsoncarries the same fix, although the check scans only.mdxfiles and cannot see this string. It is the same identifier and the same bug, so a partial revert would read as a deliberate choice to leave that file translated.Note on
CLAUDE.md:firecrawl-docs/CLAUDE.mdsays not to modify localized or translated files. This pull request edits files underes/,fr/andpt-BR/, because those files hold the wrong identifiers. Gaurav asked for this fix explicitly, so we made the exception on purpose.Recurrence warning: this only fixes the repository. The General Translation (locadex) memory still holds the translated identifiers. #1393 fixed the pages, #1394 undid them, #1406 fixed them again, and #1411 and #1413 undid them again. The next translation sync will undo this pull request too, unless
changeTracking,crawl.startedandscrapedDataare pinned as do-not-translate in the General Translation dashboard.🤖 Generated with Claude Code
https://claude.ai/code/session_017gT8R64Yuvq8jQszkLdtQo