Skip to content

FCE-3728 use actual default recording status #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czerwiukk merged 2 commits into from
Aug 13, 2026
Merged

FCE-3728 use actual default recording status #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05406a1
use active instead of unspecified
czerwiukk Aug 13, 2026
95abb2c
lint and doc
czerwiukk Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions buf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ lint:
ignore_only:
PACKAGE_VERSION_SUFFIX:
- fishjam
ENUM_ZERO_VALUE_SUFFIX:
- fishjam/server_notifications.proto
4 changes: 2 additions & 2 deletions doc/docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,7 @@ Notification sent when peer updates its metadata
<a name="fishjam-ServerMessage-RecordingStatusChanged"></a>

### ServerMessage.RecordingStatusChanged
Notification sent when a recording changes status



| Field | Type | Label | Description |
Expand Down Expand Up @@ -1963,7 +1963,7 @@ Defines message groups for which peer can subscribe

| Name | Number | Description |
| ---- | ------ | ----------- |
| STATUS_UNSPECIFIED | 0 | |
| STATUS_ACTIVE | 0 | |
| STATUS_FINISHED | 1 | |
| STATUS_AVAILABLE | 2 | |
| STATUS_FAILED | 3 | |
Expand Down
3 changes: 1 addition & 2 deletions fishjam/server_notifications.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,9 @@ message ServerMessage {
string streamer_id = 2;
}

// Notification sent when a recording changes status
message RecordingStatusChanged {
enum Status {
STATUS_UNSPECIFIED = 0;
STATUS_ACTIVE = 0;
STATUS_FINISHED = 1;
STATUS_AVAILABLE = 2;
STATUS_FAILED = 3;
Expand Down
2 changes: 1 addition & 1 deletion fishjam_protos/lib/fishjam/server_notifications.pb.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ defmodule Fishjam.ServerMessage.RecordingStatusChanged.Status do
protoc_gen_elixir_version: "0.17.0",
syntax: :proto3

field :STATUS_UNSPECIFIED, 0
field :STATUS_ACTIVE, 0
field :STATUS_FINISHED, 1
field :STATUS_AVAILABLE, 2
field :STATUS_FAILED, 3
Expand Down
Loading