Skip to content

fix: Workaround for the TextBoxComponent entering an endless loop #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzanardo merged 1 commit into from
Jul 1, 2026
+17 −1
Merged

fix: Workaround for the TextBoxComponent entering an endless loop #3939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/flame/lib/src/components/text_box_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,23 @@ class TextBoxComponent<T extends TextRenderer> extends TextComponent {
var offset = 0;

while (offset < text.length) {
final range = textPainter.getLineBoundary(TextPosition(offset: offset));
var range = textPainter.getLineBoundary(TextPosition(offset: offset));
// Flutter web sometimes report the range on the previous page instead of
// the following. This is probably a bug cause by the
// JS floating number inaccuracies.
//
// We have an issue tracking that down on Flutter itself:
// https://github.com/flutter/flutter/issues/188874
//
// This code is a workaround, that captures when such we fall
// in that issue and tries to get the next page.
if (range.start < offset) {
range = textPainter.getLineBoundary(
TextPosition(
offset: offset + 1,
),
);
}
var lineText = text.substring(range.start, range.end);

// Don't include the trailing newline character in the line text
Expand Down
Loading