Skip to content

fix: Notify the component when ColorEffect resets its color filter #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spydon wants to merge 2 commits into
base: fix/text-component-opacity-shadows
Choose a base branch
from
+27 −0
Draft

fix: Notify the component when ColorEffect resets its color filter #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57eb69c
fix: Notify the component when ColorEffect resets its color filter
spydon Sep 8, 2026
cf3f86f
test: Assert on the painted text renderer in the ColorEffect reset test
spydon Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/flame/lib/src/effects/color_effect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,6 @@ class ColorEffect extends ComponentEffect<HasPaint> {
void reset() {
super.reset();
target.getPaint(paintId).colorFilter = _original;
target.onChanged();
}
}
26 changes: 26 additions & 0 deletions packages/flame/test/effects/color_effect_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,32 @@ void main() {
},
);

testWithFlameGame(
'reset notifies the component of the restored color filter',
(game) async {
final component = TextComponent<TextPaint>(text: 'foo');
await game.ensureAdd(component);

final effect = ColorEffect(
Colors.red,
EffectController(duration: 1),
);
await component.ensureAdd(effect);
game.update(0.5);
expect(
component.paintedTextRenderer.style.foreground!.colorFilter,
isNotNull,
);

effect.reset();

expect(
component.paintedTextRenderer.style.foreground!.colorFilter,
isNull,
);
},
);

testWithFlameGame(
'can be re-added in the component tree',
(game) async {
Expand Down
Loading