Skip to content

Keep Catalog Changes tags compact and filterable - #3092

Merged
moshloop merged 1 commit into
mainfrom
fix/catalog-changes-tag-overflow
Aug 19, 2026
Merged

Keep Catalog Changes tags compact and filterable#3092
moshloop merged 1 commit into
mainfrom
fix/catalog-changes-tag-overflow

Conversation

@adityathebe

@adityathebe adityathebe commented Aug 14, 2026

Copy link
Copy Markdown
Member

Keeps Catalog Changes rows single-line by narrowing the Last Seen column and collapsing excess tags behind a +N more popover, while preserving include/exclude filtering for every hidden tag and adding an interactive Storybook regression scenario with unit coverage.

image

Summary by CodeRabbit

  • New Features

    • Added compact tag displays with overflow tags available in a popover.
    • Added include and exclude filtering controls for hidden tags.
    • Added URL-driven tag filtering to configuration change views.
  • Improvements

    • Improved table column sizing for tags and last-seen timestamps.
    • Expanded configuration change examples with realistic metadata and policy violations.
  • Bug Fixes

    • Hidden tags remain filterable and visible after selection without triggering row navigation.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aws-preview Ready Ready Preview Aug 14, 2026 10:35am
flanksource-ui Ready Ready Preview Aug 14, 2026 10:35am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d5ced30-bf8d-4f9d-a22f-f36367977ac7

📥 Commits

Reviewing files that changed from the base of the PR and between 8abe5e9 and f0239d3.

📒 Files selected for processing (5)
  • src/components/Configs/Changes/ConfigChangeTable.stories.tsx
  • src/components/Configs/Changes/ConfigChangeTable.tsx
  • src/components/Configs/ConfigList/Cells/MRTConfigListTagsCell.tsx
  • src/ui/Tags/TagsFilterCell.tsx
  • src/ui/Tags/__tests__/TagsFilterCell.unit.test.tsx

Walkthrough

The change adds compact tag rendering with a popover for hidden tags and include/exclude filtering. Configuration tables pass the visibility limit and use updated column sizing. The configuration-change story filters fixtures from URL parameters and supplies complete pagination data.

Changes

Tag display and filtering

Layer / File(s) Summary
Compact tag popover behavior
src/ui/Tags/TagsFilterCell.tsx, src/ui/Tags/__tests__/TagsFilterCell.unit.test.tsx
TagsFilterCell supports maxVisibleTags, displays hidden tags in a popover, updates the labels URL parameter, and prevents row-click propagation.
Configuration table tag wiring
src/components/Configs/ConfigList/Cells/MRTConfigListTagsCell.tsx, src/components/Configs/Changes/ConfigChangeTable.tsx
Configuration list cells pass maxVisibleTags. The change table shows one tag and applies updated tag and “Last Seen” column widths.
Configuration-change story filtering
src/components/Configs/Changes/ConfigChangeTable.stories.tsx
The story filters fixture records from URL tags, updates totalRecords, uses fullscreen layout styling, and defines complete fixture and pagination arguments.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant TagsFilterCell
  participant MemoryRouter
  participant ParentRow
  User->>TagsFilterCell: Open more-tags popover
  TagsFilterCell-->>User: Show hidden tags and include/exclude actions
  User->>TagsFilterCell: Select a tag action
  TagsFilterCell->>MemoryRouter: Update labels search parameter
  TagsFilterCell--xParentRow: Stop row-click propagation
Loading

Merge Risk: ⚪ Minimal · up to f0239

This localized UI change has no identified merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: compact, filterable tags for Catalog Changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/catalog-changes-tag-overflow
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/catalog-changes-tag-overflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adityathebe
adityathebe marked this pull request as ready for review August 14, 2026 15:55
@adityathebe
adityathebe requested a review from moshloop August 14, 2026 15:55
@moshloop
moshloop merged commit 96d409b into main Aug 19, 2026
16 of 18 checks passed
@moshloop
moshloop deleted the fix/catalog-changes-tag-overflow branch August 19, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants