Skip to content

fix: expand scraper code editor - #3093

Merged
moshloop merged 1 commit into
mainfrom
fix/scraper-code-editor-height
Aug 19, 2026
Merged

fix: expand scraper code editor#3093
moshloop merged 1 commit into
mainfrom
fix/scraper-code-editor-height

Conversation

@adityathebe

@adityathebe adityathebe commented Aug 18, 2026

Copy link
Copy Markdown
Member

Catalog scraper form specs render Monaco inside the Form/Code tabs, but the Code-tab wrapper had no height, causing the editor to collapse.

Apply the existing viewport-capped 600px editor height and add a LastFM scraper Storybook case that opens the Code tab for review.

Before and after

Before After
Collapsed scraper code editor before the fix Expanded scraper code editor after the fix

Summary by CodeRabbit

  • New Features

    • Added a Storybook scenario for viewing catalog scraper specifications in the Code tab.
    • Added support for loading and displaying parsed YAML scraper configurations in the HTTP editor.
  • Style

    • Improved the Code tab layout for form-based editing.

Form-based scraper specs rendered Monaco inside a wrapper with no height, causing the Code tab to collapse to its border and padding.

Apply the same viewport-capped editor height used by code-only specs and add a realistic LastFM scraper story that opens the Code tab automatically.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0139f-11bd-773c-9bba-5f1d820c603a
@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aws-preview Ready Ready Preview Aug 18, 2026 7:26am
flanksource-ui Ready Ready Preview Aug 18, 2026 7:26am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e8e2f7a9-b81c-4318-826e-cba76b48b5e9

📥 Commits

Reviewing files that changed from the base of the PR and between 8abe5e9 and 14011ee.

📒 Files selected for processing (2)
  • src/components/Forms/SpecEditorForm.stories.tsx
  • src/components/Forms/SpecEditorForm.tsx

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


Walkthrough

Added a CatalogScraperCodeTab Storybook story with parsed fixture data, HTTP editor configuration, and automated Code tab selection. Updated the form-mode code editor with a flex-column layout.

Changes

Catalog scraper Code tab

Layer / File(s) Summary
Storybook scenario and editor setup
src/components/Forms/SpecEditorForm.stories.tsx
Added YAML parsing, HTTP configuration support, catalog scraper fixture data, and a play function that selects the Code tab.
Code editor layout
src/components/Forms/SpecEditorForm.tsx
Added a flex-column layout class to the form-mode Code tab editor.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: expanding the scraper code editor.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/scraper-code-editor-height
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/scraper-code-editor-height

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adityathebe
adityathebe requested a review from moshloop August 18, 2026 07:38
@moshloop
moshloop merged commit df42d5a into main Aug 19, 2026
16 of 18 checks passed
@moshloop
moshloop deleted the fix/scraper-code-editor-height branch August 19, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants