chore(snmp_trap): update README for snmp_trap#1455
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the SNMP trap plugin documentation/examples to better present metric aggregation/mapping options by moving the fields_to_labels documentation earlier and adding the same section to the shipped sample trap.toml.
Changes:
- Reordered the
fields_to_labelsdocumentation block in the SNMP trap README to appear before varbind mapping. - Added a “Metric Aggregation and Mapping” example section (fields-to-labels, varbind mapping, trap mapping) to
conf/input.snmp_trap/trap.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| inputs/snmp_trap/README.md | Reorders the sample config documentation so fields_to_labels appears before varbind mapping. |
| conf/input.snmp_trap/trap.toml | Adds corresponding commented sample config for metric aggregation/mapping options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kongfei605
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.