feat(cli): drop pure-rename curated shadows (insight team/channel/responder, member list)#48
Merged
Merged
Conversation
…ponder, member list)
Continues the generated-as-single-source convergence (after the table
renderer and relative-time keystones). Removes the curated commands whose
only difference from their generated twin is flag spelling — a clean rename,
now that generated --start-time/--end-time accept relative time:
- insight team/channel/responder: curated --since/--until → generated
--start-time/--end-time (relative-time capable) PLUS the generated twin
exposes severities, *_ids, fields, aggregate-unit, … (net gain).
- member list: curated --name/--email → generated --query (the curated
command already folded both into the SDK Query field; generated also
keeps --role-id/--orderby/--asc and adds the rest of the member API).
To preserve the curated human tables, the generic renderer gains an
optional per-column formatter (colSpec.Format); DimensionInsightItem and
ResponderInsightItem seeds render ACK%/MTTA/MTTR with the same percent/
duration formatting the curated tables used. json/toon output unchanged.
insight top-alerts and incidents are KEPT curated for now — their generated
twins differ by more than flag spelling (--limit→--k, offset→cursor
pagination), so they're not pure renames.
e2e: member filter tests migrated to --query.
Doc/scan.sh references in fc-safari migrate in a paired PR; the dropped
commands only disappear for agents once a new CLI is released into the
sandbox, so the two land together.
ysyneu
added a commit
that referenced
this pull request
Jun 15, 2026
…re-rename shadows, #50 positional args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Third step of the generated-as-single-source convergence (after #46 table renderer + #47 relative-time). Deletes the curated "shadow" commands whose only difference from their generated twin is flag spelling — a clean rename, made non-regressing by #47 (generated
--start-time/--end-timenow accept relative time).insight team/channel/responder--since/--until→--start-time/--end-time(relative-capable) + twin exposesseverities,*_ids,fields,aggregate-unit, …member list--name/--email→--query(curated already folded both into the SDKQueryfield); keeps--role-id/--orderby/--asc, adds the restKept curated (NOT pure renames — deferred):
insight top-alerts(--limit→--k),insight incidents(offset→cursor pagination).Preserving the human tables
The generic renderer (#46) only auto-formats timestamps, so dropping the curated insight tables would print raw floats (
0.85,150). Added an optional per-column formatter (colSpec.Format) +DimensionInsightItem/ResponderInsightItemseeds soACK%/MTTA/MTTRrender with the same percent/duration formatting as before. json/toon output is unchanged.Verification
go build/vet/test ./...green;go vet -tags=e2e ./e2e/clean; gofumpt clean.TestRenderGenericTable_FormattedColumns(percent/duration path) +TestDisplayColumns_FieldsResolveextended with the two new row types (guards field-name typos against go-flashduty v0.5.4 — all verified present).member list --query areturns a formatted table;insight team --start-time 30d --end-time nowaccepted with the rich flag set; old--sincecorrectly gone.Lockstep / release-gating
The agent skill-doc +
scan.shreferences in fc-safari migrate in a paired PR. The dropped commands only disappear for agents once a new flashduty-cli is released into the sandbox image, so the CLI release and the fc-safari doc PR land together (no mid-window breakage on the dev env).Known cosmetic:
DimensionInsightItembacks bothinsight teamandinsight channel, so the table shows bothTEAMandCHANNELcolumns (the irrelevant one empty per query).