feat(cli): incident info --num + channel team/creator names (fc-event#1674)#52
Merged
Conversation
…#1674) Propagate fc-event#1674 through the generated layer by bumping go-flashduty to the synced+regenerated spec, plus a cligen enhancement so the now-optional incident_id stays back-compatible: - incident info: new --num flag (server-side 6-char short-id lookup); incident_id relaxed to optional. Add an OPTIONAL positional mode to cligen (optionalArg + positional.Optional + optionalPositional map) so `incident info <id>` keeps working while `incident info --num CBE249` resolves and bare `incident info` (with --num) is valid; `incident info a b` still rejected. - channel list/info: response help documents team_name + creator_name. go-flashduty pinned to the chore/enrich-1674-spec commit (pseudo-version); re-pin to the released version after go-flashduty#11 merges. Build + unit tests (incl. gen_positional) pass.
ysyneu
added a commit
that referenced
this pull request
Jun 16, 2026
#52 merged at the pre-re-pin commit, so feat/ai-sre pinned the go-flashduty#11 PR-branch commit (da82c4) rather than the squash-merged main commit. Re-pin to go-flashduty main (54d4fc1) so the dependency tracks main, not an orphaned PR-branch commit kept alive only by the closed PR. Generated output unchanged (identical spec); build + unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final link in the docs → SDK → CLI chain for fc-event#1674. Depends on go-flashduty#11 (pins its branch commit via pseudo-version).
Changes
incident info— new--numflag (server-side 6-char short-id lookup; the backend relaxedincident_idto optional and resolvesnumto the most-recent match). This replaces the old client-sideincident list --query <num>→incident infotwo-step dance for the generated twin.channel list/channel info— response help now documentsteam_name+creator_name; the fields flow through the regenerated go-flashdutyChannelItem(visible in--json/--toon).cligen enhancement — optional positional (no back-compat loss)
Relaxing
incident_idto optional would have dropped the generatedincident info <id>positional (cligen only pins required*_idfields →gen_positional_testcontract break). Rather than lose it, added a 0-or-1 optional positional mode:positional.Optional+optionalPositionalmap (pinsincidentInfo→incident_id, marked optional)optionalArg(name)validator (0-or-1; rejects >1)Result:
Verification
go build ./...+go test ./internal/...(incl. updatedgen_positional) pass. End-to-end smoke confirms the Usage lineincident info [<incident-id>]and arg arities.Landing note
go-flashduty is pinned to the
chore/enrich-1674-speccommit as a pseudo-version so this PR is CI-green now. After go-flashduty#11 merges + releases, re-pin go.mod to the released version (one-linego get), then this is final.Chain (merge in order)
mainmain(+ release)feat/ai-sre