Skip to content

fix: make green on darwin (dead broker stub + fmt worktree scope) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysyneu merged 2 commits into from
Jun 11, 2026
Merged

fix: make green on darwin (dead broker stub + fmt worktree scope) #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f339037
fix(broker): drop dead non-Linux serveBrokerControl stub
ysyneu Jun 11, 2026
0dd0338
build: scope gofumpt/gci to module files, not .claude/ worktrees
ysyneu Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ GOLINT := golangci-lint
# Binary name
BINARY_NAME := flashduty-runner

# Go source files to format. Prune .claude/ so the filesystem-walking formatters
# (gofumpt, gci) never reach git worktrees of other branches living under
# .claude/worktrees/. go mod tidy and golangci-lint are module-aware and skip
# those nested modules on their own.
GO_SRC := $(shell find . -path ./.claude -prune -o -name '*.go' -print)

all: fmt lint test build

# Build the binary
Expand Down Expand Up @@ -57,14 +63,14 @@ lint:
# Format code
fmt:
@echo "Formatting code..."
gofumpt -l -w .
gofumpt -l -w $(GO_SRC)
gci write --skip-generated \
--section standard \
--section default \
--section "prefix(github.com/flashcat)" \
--section alias \
--section blank \
.
$(GO_SRC)
$(GOMOD) tidy

# Tidy dependencies
Expand Down
4 changes: 0 additions & 4 deletions environment/broker_other.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,3 @@ var errBrokerUnsupportedPlatform = errors.New("broker not supported on this plat
func setupBrokerForCmd(*exec.Cmd, *protocol.BashCredential) (func(), []string, error) {
return nil, nil, errBrokerUnsupportedPlatform
}

func serveBrokerControl(int, string, string) (func(), error) {
return func() {}, errBrokerUnsupportedPlatform
}
Loading