chore: sync spec + regen for incident num + channel team/creator names#11
Merged
Conversation
Sync the vendored OpenAPI from flashduty-docs (fc-event#1674 enrichment) and
regenerate the typed model layer:
- IncidentInfoRequest.Num — incident/info short-id (num) lookup.
- ChannelItem.TeamName / ChannelItem.CreatorName — channel/list enrichment.
Vendored openapi/{en,zh}.json synced from flashduty-docs; models_gen.go
regenerated via `make generate`. go vet + unit tests (incl. roundtrip) pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second link in the docs → SDK → CLI chain for fc-event#1674. Depends on flashduty-docs#89.
Changes
IncidentInfoRequest.Num—incident/infoshort-id (num) lookup.ChannelItem.TeamName/ChannelItem.CreatorName—channel/listenrichment.Produced by
make sync-spec(vendoredopenapi/{en,zh}.jsonfrom the docs spec) +make generate. Diff is exactly the 3 fields inmodels_gen.go(+6) plus the vendored spec sync — no churn inservices_gen.goor other models.Verification
go vetclean; root unit tests pass (includingroundtrip_gen_testschema round-trip).Chain (merge in order)
mainmain— then tag/release so the CLI can pin itfeat/ai-sre(pins this commit, regenerates the--numflag + channel fields)