Support globalshortcuts - #226
Conversation
fafc928 to
e91c85f
Compare
8598060 to
6d2cbb9
Compare
|
I now also added a test for the shortcut_changed signal |
|
I saw your ping at me yesterday but someone else should review this. I am not familiar with the portal implementation. If something needs to merged after reviews etc. let me know. |
|
Can then someone else please review this PR? |
6d2cbb9 to
bb3493a
Compare
bb3493a to
1b65ee8
Compare
jadahl
left a comment
jadahl
left a comment
There was a problem hiding this comment.
lgtm now, just a minor nit
870e504 to
4b2951f
Compare
|
I squashed now the review changes into the original commit. |
|
I seem to have now lost permissions to this repo, not sure who changed them but I wasn't notified... |
|
@TingPing can you maybe merge and release a new version? I saw you merged recently |
|
I got mine back after some email back and forth. If Patrick or no one else is available I can do it now. |
| g_return_if_fail (G_IS_TASK (call->task)); | ||
|
|
||
| g_variant_get (parameters, "(u@a{sv})", &response, &ret); | ||
|
|
There was a problem hiding this comment.
isn't this missing the handling of response != 0 like bind_shortcuts_done?
There was a problem hiding this comment.
actually it's probably redundant in the other way since call_dispose already does it.
There was a problem hiding this comment.
Yes, it's redundant. Removed it in bind_shortcuts and session_created
1be9e02 to
4b6f87a
Compare
Co-Authored-By: dcz <gilaac.dcz@porcupinefactory.org>
4b6f87a to
afd95f5
Compare
3 participants
Sorry for opening a third PR!
Replaces #153 and #223
I discussed with @sithlord48 that I will just open a PR because I changed so much.
This is again based upon #153 but I fixed it so the leftover remains from the inputcapture files are not in it anymore and it works.
You can test it within portal-test-gtk3.
Downstream use: deskflow/deskflow#9858