Skip to content

fix: Ghostty で zoom/pan が追従しない問題を修正 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flexphere merged 2 commits into from
Mar 25, 2026
Merged

fix: Ghostty で zoom/pan が追従しない問題を修正 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab50d6b
fix: add placement ID to Kitty graphics commands for cross-terminal c…
flexphere Mar 25, 2026
9b5d2ee
test: scope placement ID assertion to command portion in DisplayMinim…
flexphere Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/adapter/renderer/kitty_renderer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (r *KittyRenderer) Display(vp *domain.Viewport) (string, error) {
// Clear previous display and show new frame
// Move cursor to top-left, clear screen area, then display
output := "\x1b[H" // move cursor to top-left
output += fmt.Sprintf("\x1b_Ga=p,i=%d,x=%d,y=%d,w=%d,h=%d,c=%d,r=%d,q=2\x1b\\",
output += fmt.Sprintf("\x1b_Ga=p,i=%d,p=1,x=%d,y=%d,w=%d,h=%d,c=%d,r=%d,q=2\x1b\\",
r.imageID, srcX, srcY, srcW, srcH, displayCols, displayRows)

return output, nil
Expand Down Expand Up @@ -217,7 +217,7 @@ func (r *KittyRenderer) DisplayMinimap(vp *domain.Viewport, cols, rows int, bord
}

// Build placement command (always needed since main image re-render may overwrite)
placeCmd := fmt.Sprintf("\x1b[%d;%dH\x1b_Ga=p,i=%d,c=%d,r=%d,z=1,q=2\x1b\\",
placeCmd := fmt.Sprintf("\x1b[%d;%dH\x1b_Ga=p,i=%d,p=1,c=%d,r=%d,z=1,q=2\x1b\\",
startRow, startCol, r.minimapID, cols, rows)

// Skip re-upload if indicator rectangle and border color haven't changed.
Expand Down
16 changes: 16 additions & 0 deletions internal/adapter/renderer/kitty_renderer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ func TestKittyRenderer_Display(t *testing.T) {
if !strings.Contains(output, "a=p") {
t.Error("output should contain action=place")
}
if !strings.Contains(output, "p=1") {
t.Error("output should contain placement ID for consistent cross-terminal behavior")
}
if !strings.Contains(output, "w=800") {
t.Error("output should contain source width")
}
Expand Down Expand Up @@ -152,6 +155,19 @@ func TestKittyRenderer_DisplayMinimap(t *testing.T) {
if !strings.Contains(output, "a=p") {
t.Error("output should contain action=place")
}
// Verify p=1 within the placement command only (not in base64 payload)
aPos := strings.Index(output, "a=p")
if aPos == -1 {
t.Fatal("output should contain action=place (a=p) command")
}
termPosRel := strings.Index(output[aPos:], "\x1b\\")
if termPosRel == -1 {
t.Fatalf("output should contain kitty graphics terminator after placement command: %q", output)
}
placementCmd := output[aPos : aPos+termPosRel]
if !strings.Contains(placementCmd, "p=1") {
t.Errorf("placement command should contain placement ID p=1 for consistent cross-terminal behavior, got: %q", placementCmd)
}
// Uses raw RGBA format
if !strings.Contains(output, "f=32") {
t.Error("output should use raw RGBA format (f=32)")
Expand Down
Loading