-
Notifications
You must be signed in to change notification settings - Fork 0
feat: tmux DCS passthrough による tmux 内画像表示対応 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
303a3f3
feat: add TmuxRenderer with DCS passthrough for tmux support
flexphere 3e4ec76
test: add TmuxRenderer unit tests
flexphere e6cf2ec
docs: add tmux support to README
flexphere 2b58198
fix: add DECSC/DECRC cursor save/restore in tmux passthrough
flexphere c80e4db
fix: validate tmux session in NewTmuxRenderer
flexphere 15da73e
fix: propagate error from queryTmuxPaneOffset
flexphere 47cbefb
refactor: use input-side scanning for cursor move extraction
flexphere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createRenderer は "tmux" を指定すると常に renderer.NewTmuxRenderer() を返しますが、tmux 外や tmux コマンド不在でもそのまま進むため(pane offset が 0,0 になりやすく)「何も表示されない/位置が不正」になっても利用者が原因を特定しづらいです。NewTmuxRenderer / createRenderer のどちらかで tmux セッション判定や依存コマンド有無チェックを行い、満たさない場合は明示的にエラーにすることを検討してください。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c80e4db で修正 — コメント #3 と同一コミットで対応しました