Add functions to restore custom buffer bookmark properties#56
Add functions to restore custom buffer bookmark properties#56shipmints wants to merge 3 commits into
Conversation
This is better than our custom code.
- New defcustoms 'bufferlo-bookmark-buffer-locals', 'bufferlo-bookmark-buffer-handler-functions'. - New defuns 'bufferlo-bookmark-map-function-buffer-locals', 'bufferlo-bookmark-buffer-handler-buffer-locals', 'bufferlo-bookmark-map-function-text-scale-mode-amount', 'bufferlo-bookmark-buffer-handler-text-scale-mode-amount'. - Update documentation.
shipmints
force-pushed
the
shipmints-bufferlo-bookmark-buffer-handler-functions
branch
from
5e517fc to
7b34bd7
Compare
|
I suppose the configuration of these two features could be simplified like we handle ibuffer integration. The hooks need to be installed in pairs so we could automate this. Nobody will want to have only half the hooks installed, right? |
|
Done. |
|
Flo, should I merge this or do you have anything outstanding? |
florommel
left a comment
florommel
left a comment
There was a problem hiding this comment.
Just a nit, bufferlo-bookmark-buffer-locals and bufferlo-bookmark-text-scale-mode-amount seem to be flipped in the README's code examples.
|
|
||
| #+begin_src emacs-lisp | ||
| ;; To persist text-scale-mode-amount | ||
| (setq bufferlo-bookmark-buffer-locals t) |
There was a problem hiding this comment.
This should be bufferlo-bookmark-text-scale-mode-amount, right?
|
|
||
| #+begin_src emacs-lisp | ||
| ;; To persist buffer-local variables | ||
| (setq bufferlo-bookmark-text-scale-mode-amount t) |
There was a problem hiding this comment.
and this should be bufferlo-bookmark-buffer-locals
|
I also think that we don't need e2cf46e anymore. PS: Great stuff, I just discovered the power of this.. now I can persist my symbol overlays with: |
2 participants
'bufferlo-bookmark-buffer-handler-functions'.
'bufferlo-bookmark-buffer-handler-buffer-locals',
'bufferlo-bookmark-map-function-text-scale-mode-amount',
'bufferlo-bookmark-buffer-handler-text-scale-mode-amount'.