Skip to content

[material_ui] Remove unused example files #12179

Open
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:remove-extra-file
Open

[material_ui] Remove unused example files #12179
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:remove-extra-file

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

These example files are not used in material_ui anywhere. They're testing widgets defined in flutter/widgets, and these examples are only referenced in docs in flutter/widgets.

This PR removes these files from material_ui. A subsequent PR will fix flutter/widgets to move these example files to flutter/widgets/examples, preserving them after the deprecation of flutter/material.

There are no cases of the same kind in cupertino_ui.

Note to reviewers: This is not a blocker to the 1.0 release, since it's a no-op. I'm happy to postpone this PR if deemed necessary.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 10, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes multiple example files and their corresponding widget tests related to context menus, platform menu bars, and selection containers. Feedback indicates that deleting editable_text_toolbar_builder.2.dart will break an existing documentation reference in adaptive_text_selection_toolbar.dart, which must be updated or removed to prevent build failures.

@dkwingsmt dkwingsmt force-pushed the remove-extra-file branch from e129f19 to a59085c Compare July 10, 2026 22:38
@github-actions github-actions Bot removed the CICD Run CI/CD label Jul 10, 2026
@dkwingsmt dkwingsmt added the CICD Run CI/CD label Jul 10, 2026
@dkwingsmt

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several example files and their corresponding widget tests related to context menus, platform menu bars, selectable regions, and selection containers. I have no feedback to provide as there are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant