[material_ui] Remove unused example files #12179
Open
dkwingsmt wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes multiple example files and their corresponding widget tests related to context menus, platform menu bars, and selection containers. Feedback indicates that deleting editable_text_toolbar_builder.2.dart will break an existing documentation reference in adaptive_text_selection_toolbar.dart, which must be updated or removed to prevent build failures.
e129f19 to
a59085c
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several example files and their corresponding widget tests related to context menus, platform menu bars, selectable regions, and selection containers. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These example files are not used in
material_uianywhere. They're testing widgets defined influtter/widgets, and these examples are only referenced in docs influtter/widgets.This PR removes these files from
material_ui. A subsequent PR will fixflutter/widgetsto move these example files toflutter/widgets/examples, preserving them after the deprecation offlutter/material.There are no cases of the same kind in
cupertino_ui.Note to reviewers: This is not a blocker to the 1.0 release, since it's a no-op. I'm happy to postpone this PR if deemed necessary.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2