[camera_android_camerax] Bump cameraxVersion to 1.6.2, remove concurrent-futures workaround - #12698
[camera_android_camerax] Bump cameraxVersion to 1.6.2, remove concurrent-futures workaround#12698dhc-tech wants to merge 4 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the cameraxVersion from 1.6.1 to 1.6.2 in build.gradle.kts and removes the explicit androidx.concurrent:concurrent-futures dependency workaround along with its associated regression test, ConcurrentFuturesDependencyTest.java. The package version is bumped to 0.7.4+8 in pubspec.yaml and documented in CHANGELOG.md. There are no review comments, and I have no feedback to provide.
camera-core 1.6.2 includes an upstream fix removing the JSpecify type-use annotation that required consumers to explicitly declare androidx.concurrent:concurrent-futures on their compile classpath (https://issuetracker.google.com/issues/543937345). With 1.6.2, that workaround (added previously) is no longer needed, so this removes the explicit dependency and its regression test.
c77b740 to
da512c3
Compare
Bumps
cameraxVersionfrom 1.6.1 to 1.6.2. This release includes an upstreamfix (https://issuetracker.google.com/issues/543937345) removing the JSpecify
type-use annotation that required consumers to explicitly declare
androidx.concurrent:concurrent-futureson their compile classpath. With1.6.2, that workaround (added in #12373) is no longer needed, so this PR
removes the explicit dependency and its regression test.
Verified the fix is actually present in the published 1.6.2 artifact by
decompiling
SurfaceRequest.classfromcamera-core-1.6.2.aar— themSurfaceRecreationCompleterfield no longer carries the JSpecify@NonNulltype annotation that caused the original compile failure.Fixes flutter/flutter#190505
Pre-Review Checklist
0.7.4+8).///). N/A — no public API surface changed, only a build-file dependency version bump.ConcurrentFuturesDependencyTest) existed solely to guard the now-unnecessary workaround dependency from [camera_android_camerax] Add explicit concurrent-futures dependency #12373, so deleting it alongside the dependency is correct rather than requiring a replacement test.