Skip to content

[cupertino_ui] Add SemanticsRole.slider to CupertinoSlider #12710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hannah-hyj wants to merge 1 commit into
base: main
Choose a base branch
from
+77 −11
Draft

[cupertino_ui] Add SemanticsRole.slider to CupertinoSlider #12710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 55 additions & 10 deletions packages/cupertino_ui/lib/src/slider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ class _CupertinoSliderState extends State<CupertinoSlider> with TickerProviderSt
Widget build(BuildContext context) {
return _CupertinoSliderRenderObjectWidget(
value: (widget.value - widget.min) / (widget.max - widget.min),
min: widget.min,
max: widget.max,
divisions: widget.divisions,
activeColor: CupertinoDynamicColor.resolve(
widget.activeColor ?? CupertinoTheme.of(context).primaryColor,
Expand All @@ -311,6 +313,8 @@ class _CupertinoSliderState extends State<CupertinoSlider> with TickerProviderSt
class _CupertinoSliderRenderObjectWidget extends LeafRenderObjectWidget {
const _CupertinoSliderRenderObjectWidget({
required this.value,
required this.min,
required this.max,
this.divisions,
required this.activeColor,
required this.thumbColor,
Expand All @@ -321,6 +325,8 @@ class _CupertinoSliderRenderObjectWidget extends LeafRenderObjectWidget {
});

final double value;
final double min;
final double max;
final int? divisions;
final Color activeColor;
final Color thumbColor;
Expand All @@ -334,6 +340,8 @@ class _CupertinoSliderRenderObjectWidget extends LeafRenderObjectWidget {
assert(debugCheckHasDirectionality(context));
return _RenderCupertinoSlider(
value: value,
min: min,
max: max,
divisions: divisions,
activeColor: activeColor,
thumbColor: CupertinoDynamicColor.resolve(thumbColor, context),
Expand All @@ -352,6 +360,8 @@ class _CupertinoSliderRenderObjectWidget extends LeafRenderObjectWidget {
assert(debugCheckHasDirectionality(context));
renderObject
..value = value
..min = min
..max = max
..divisions = divisions
..activeColor = activeColor
..thumbColor = CupertinoDynamicColor.resolve(thumbColor, context)
Expand All @@ -374,18 +384,30 @@ const double _kAdjustmentUnit = 0.1; // Matches iOS implementation of material s

class _RenderCupertinoSlider extends RenderConstrainedBox implements MouseTrackerAnnotation {
_RenderCupertinoSlider({
required this._value,
this._divisions,
required this._activeColor,
required this._thumbColor,
required this._trackColor,
this._onChanged,
required double value,
required double min,
required double max,
int? divisions,
required Color activeColor,
required Color thumbColor,
required Color trackColor,
_SliderValueChanged? onChanged,
this.onChangeStart,
this.onChangeEnd,
required TickerProvider vsync,
required this._textDirection,
this._cursor = MouseCursor.defer,
}) : assert(_value >= 0.0 && _value <= 1.0),
required TextDirection textDirection,
MouseCursor cursor = MouseCursor.defer,
}) : assert(value >= 0.0 && value <= 1.0),
_value = value,
_min = min,
_max = max,
_divisions = divisions,
_activeColor = activeColor,
_thumbColor = thumbColor,
_trackColor = trackColor,
_onChanged = onChanged,
_textDirection = textDirection,
_cursor = cursor,
super(
additionalConstraints: const BoxConstraints.tightFor(
width: _kSliderWidth,
Expand Down Expand Up @@ -419,6 +441,26 @@ class _RenderCupertinoSlider extends RenderConstrainedBox implements MouseTracke
markNeedsSemanticsUpdate();
}

double get min => _min;
double _min;
set min(double newMin) {
if (newMin == _min) {
return;
}
_min = newMin;
markNeedsSemanticsUpdate();
}

double get max => _max;
double _max;
set max(double newMax) {
if (newMax == _max) {
return;
}
_max = newMax;
markNeedsSemanticsUpdate();
}

int? get divisions => _divisions;
int? _divisions;
set divisions(int? value) {
Expand Down Expand Up @@ -623,11 +665,14 @@ class _RenderCupertinoSlider extends RenderConstrainedBox implements MouseTracke

config.isSemanticBoundary = isInteractive;
config.isSlider = true;
config.role = SemanticsRole.slider;
config.minValue = min.toString();
config.maxValue = max.toString();
Comment on lines +669 to +670

@gemini-code-assist gemini-code-assist Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

In Flutter's SemanticsConfiguration, minValue and maxValue are of type double?, not String?. Assigning a String (via toString()) will cause a compile-time type mismatch error. They should be assigned directly as double values.

Suggested change
config.minValue = min.toString();
config.maxValue = max.toString();
config.minValue = min;
config.maxValue = max;

config.value = '${(value * 100).round()}%';
if (isInteractive) {
config.textDirection = textDirection;
config.onIncrease = _increaseAction;
config.onDecrease = _decreaseAction;
config.value = '${(value * 100).round()}%';
config.increasedValue =
'${(clampDouble(value + _semanticActionUnit, 0.0, 1.0) * 100).round()}%';
config.decreasedValue =
Expand Down
3 changes: 3 additions & 0 deletions packages/cupertino_ui/pending_changelogs/slider_semantics_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog: |
- Adds `SemanticsRole.slider` and min/max value bounds to `CupertinoSlider` semantics.
version: patch
20 changes: 19 additions & 1 deletion packages/cupertino_ui/test/slider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,9 @@ void main() {
tester.getSemantics(find.byType(CupertinoSlider)),
matchesSemantics(
isSlider: true,
role: SemanticsRole.slider,
minValue: '0.0',
maxValue: '1.0',
Comment on lines +446 to +447

@gemini-code-assist gemini-code-assist Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since minValue and maxValue are double values, they should be matched as double literals rather than strings in matchesSemantics.

Suggested change
minValue: '0.0',
maxValue: '1.0',
minValue: 0.0,
maxValue: 1.0,

hasIncreaseAction: true,
hasDecreaseAction: true,
value: '50%',
Expand All @@ -462,7 +465,16 @@ void main() {
),
);

expect(tester.getSemantics(find.byType(CupertinoSlider)), matchesSemantics(isSlider: true));
expect(
tester.getSemantics(find.byType(CupertinoSlider)),
matchesSemantics(
isSlider: true,
role: SemanticsRole.slider,
minValue: '0.0',
maxValue: '1.0',
Comment on lines +473 to +474

@gemini-code-assist gemini-code-assist Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since minValue and maxValue are double values, they should be matched as double literals rather than strings in matchesSemantics.

Suggested change
minValue: '0.0',
maxValue: '1.0',
minValue: 0.0,
maxValue: 1.0,

value: '50%',
),
);

handle.dispose();
});
Expand All @@ -483,6 +495,9 @@ void main() {
tester.getSemantics(find.byType(CupertinoSlider)),
matchesSemantics(
isSlider: true,
role: SemanticsRole.slider,
minValue: '0.0',
maxValue: '1.0',
Comment on lines +499 to +500

@gemini-code-assist gemini-code-assist Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since minValue and maxValue are double values, they should be matched as double literals rather than strings in matchesSemantics.

Suggested change
minValue: '0.0',
maxValue: '1.0',
minValue: 0.0,
maxValue: 1.0,

hasIncreaseAction: true,
hasDecreaseAction: true,
value: '50%',
Expand All @@ -506,6 +521,9 @@ void main() {
tester.getSemantics(find.byType(CupertinoSlider)),
matchesSemantics(
isSlider: true,
role: SemanticsRole.slider,
minValue: '0.0',
maxValue: '1.0',
Comment on lines +525 to +526

@gemini-code-assist gemini-code-assist Bot Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since minValue and maxValue are double values, they should be matched as double literals rather than strings in matchesSemantics.

Suggested change
minValue: '0.0',
maxValue: '1.0',
minValue: 0.0,
maxValue: 1.0,

hasIncreaseAction: true,
hasDecreaseAction: true,
value: '60%',
Expand Down
Loading