[google_maps_flutter] Convert heatmap controller to Swift - #12713
Open
stuartmorgan-g wants to merge 16 commits into
Open
[google_maps_flutter] Convert heatmap controller to Swift#12713stuartmorgan-g wants to merge 16 commits into
stuartmorgan-g wants to merge 16 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the heatmap controller and data conversion logic from Objective-C to Swift across the iOS packages (sdk9, sdk10, and shared_code), removing several Objective-C files in favor of Swift implementations. The review feedback highlights critical safety issues, pointing out potential runtime crashes from unsafely unwrapping optional values like heatmap.gradient and heatmap.weightedData. Additionally, the reviewer suggests performance optimizations, such as avoiding unnecessary CLLocation heap allocations by passing CLLocationCoordinate2D directly to path-creation helpers, and refactoring redundant image loading logic in ImageUtils.swift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts HeatmapController and the remaining utility functions to Swift in the
_sdk*packages.The final remaining Obj-C code will be migrated in a follow-up PRs.
The conversion process was:
The conversion code utils have much more change than previous PRs, since the direct conversion code felt very non-idiomatic in Swift. Almost all of the free functions for Pigeon<->Maps SDK type conversions were converted to extensions on the Pigeon types:
make(from:)toMapsSDKClassName()method on the Pigeon type (I'm not sold on that naming pattern; alternate suggestions welcome)mapthat conversion function, sincemapis a simple and idiomatic pattern in Swift, unlike the loop-and-add construction that had been required in Obj-C.The test bridging header is removed since there are no longer any
_Testheaders.Part of flutter/flutter#119108
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2