Skip to content

[file_selector_android] Handle a null stream from openInputStream - #12716

Open
mboetger wants to merge 1 commit into
flutter:mainfrom
mboetger:fix-null-191989
Open

[file_selector_android] Handle a null stream from openInputStream#12716
mboetger wants to merge 1 commit into
flutter:mainfrom
mboetger:fix-null-191989

Conversation

@mboetger

@mboetger mboetger commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Null safety when ContentResolver cannot open a stream.

Copied from closed: #12683

Fixes: #191989

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a crash that occurs when the Android content provider returns a null input stream for a selected file. It introduces null checks for the input stream in FileSelectorApiImpl.java and FileUtils.java, returning null or throwing an IOException respectively. Corresponding unit tests have been added to verify these behaviors, and the package version has been bumped to 0.5.2+11. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant