CUJ index [land silently] by ericwindmill · Pull Request #13769 · flutter/website

ericwindmill · 2026-08-20T19:36:25Z

Description of what this PR is changing or adding, and why:

This PR adds a CUJ index page, which is landed silently for now. This is an effort to break up the currently massive #13691

Extract generic two-column filterable index layout styles and sidebar/search components from learning resources into reusable filterable_index.dart and _filterable-index.scss.

Adds the canonical Critical User Journeys (CUJs) data, data model, filterable index page components, and styling for /ai/flutter-bench/cujs.

flutter-website-bot · 2026-08-20T19:44:16Z

Staged preview of the updated docs.flutter.dev site (updated for commit b4619e5):

https://flutter-docs-prod--docs-pr13769-cuj-index-ucwmiabz.web.app

flutter-website-bot · 2026-08-20T19:52:00Z

Staged preview of the updated flutter.dev site (updated for commit b4619e5):

https://flutter-dev-230821--www-pr13769-cuj-index-eerbuymc.web.app

# Conflicts: # sites/docs/lib/_sass/components/_filterable-index.scss # sites/docs/lib/src/components/pages/filterable_index.dart # sites/docs/lib/src/components/pages/learning_resource_filters_sidebar.dart

…site into cuj-index

gemini-code-assist

Code Review

This pull request introduces a new Critical User Journey (CUJ) index page, including a catalog of journeys, search and filter capabilities, and responsive styling. The feedback highlights several critical syntax errors where .text(...) is used instead of Text(...), which will cause compilation failures. Additionally, the reviewer pointed out potential runtime crashes related to unsafe type casting of page data and checkbox states, a potential exception from calling setState on an unmounted widget, and recommended using a more specific CSS selector for querying card elements.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

lamek

LGTM on the docs stuff. I added some fixes and suggestions. I'll leave the code review to Parker and Killian.

Page I reviewed: https://flutter-docs-prod--docs-pr13769-cuj-index-ucwmiabz.web.app/ai/flutter-bench/cujs

lamek · 2026-08-26T19:35:59Z

+concrete tasks they take to get there.
+
+Product teams at Google treat CUJs as a source of truth: they're how teams align
+on priorities, shape roadmaps, measure product health and more. And we use


Add comma: "...manage health, and more."

lamek · 2026-08-26T19:36:19Z

+concrete tasks they take to get there.
+
+Product teams at Google treat CUJs as a source of truth: they're how teams align
+on priorities, shape roadmaps, measure product health and more. And we use


Remove the leading "And" --> "The Flutter team uses CUJs..."

lamek · 2026-08-26T19:37:52Z

+
+The catalog below is the Flutter team's CUJs. It's a claim about what matters in
+Flutter development. If the way you build Flutter apps isn't represented here,
+the list is incomplete, and we encourage [your feedback][].


"... you to open an issue with your feedback."

Suggest adding this to make it clear what the user should do once they land on the issues page.

lamek · 2026-08-26T19:39:18Z

+
+[FlutterBench]: /ai/flutter-bench
+
+[critical user journey]: https://static.googleusercontent.com/media/sre.google/en//static/pdf/art-of-slos-handbook-a4.pdf


Is this the correct thing to link to? I see the section on user journeys, but the PDF is mostly about SLOs.

ah shoot that isn't right, I meant to return to this

lamek · 2026-08-26T19:40:44Z

+shortTitle: Flutter CUJs
+description: >
+  Browse the catalog of canonical Flutter and Dart critical user journeys 
+  (CUJs). FlutterBench evals measures these CUJs.


measures --> measure (remove the "s")

lamek · 2026-08-26T19:41:34Z

+on priorities, shape roadmaps, measure product health and more. And we use
+CUJs to derive evaluation tasks and prompts for [FlutterBench][].
+
+The catalog below is the Flutter team's CUJs. It's a claim about what matters in


Suggest changing "is the" to "lists"

"The catalog below lists the Flutter..."

lamek · 2026-08-26T19:42:46Z

+
+A _[critical user journey][]_ (CUJ) is a goal a developer sets out to
+accomplish, like "make an application accessible to all users" or
+"diagnose and resolve layout overflow errors" and it's broken down into the


Add a comma after "errors"

...layout overflow errors", and it's...

sfshaza2

I'm a bit confused here. I looked at the staged site and I can't find the /ai/flutter-bench page that is referred to in the PR. I know that @jesskuras's restructuring PR does have that page, so is this PR waiting for her PR to land? If so, maybe mark this as draft...

ericwindmill · 2026-08-27T16:42:49Z

I'm a bit confused here. I looked at the staged site and I can't find the /ai/flutter-bench page that is referred to in the PR. I know that @jesskuras's restructuring PR does have that page, so is this PR waiting for her PR to land? If so, maybe mark this as draft...

The path will change depending on Jess's change's, so I'm just waiting for that PR to land to know what to update it to.

parlough

Cool! Generally looking good to me. Some small suggestions:

parlough · 2026-08-27T20:04:43Z

+description: >
+  Browse the catalog of canonical Flutter and Dart critical user journeys 
+  (CUJs). FlutterBench evals measures these CUJs.


Consider tightening this to a single sentence:

Suggested change

description: >

Browse the catalog of canonical Flutter and Dart critical user journeys

(CUJs). FlutterBench evals measures these CUJs.

description: >-

Browse the catalog of canonical Flutter and Dart critical user journeys that

the FlutterBench evaluations test.

parlough · 2026-08-27T20:06:59Z

+on priorities, shape roadmaps, measure product health and more. And we use
+CUJs to derive evaluation tasks and prompts for [FlutterBench][].
+
+The catalog below is the Flutter team's CUJs. It's a claim about what matters in


Change "The catalog below" to "The following catalog".

parlough · 2026-08-27T20:10:45Z

+A _[critical user journey][]_ (CUJ) is a goal a developer sets out to
+accomplish, like "make an application accessible to all users" or
+"diagnose and resolve layout overflow errors" and it's broken down into the
+concrete tasks they take to get there.


This is a long sentence. Consider breaking it up into two. Perhaps something like:

A _[critical user journey][]_ (CUJ) is a goal that a developer sets out to accomplish, such as "make an application accessible to all users" or "diagnose and resolve layout overflow errors". Each CUJ is broken down into the concrete tasks required to complete it.

parlough · 2026-08-27T20:14:27Z

+
+<CujIndex />
+
+[FlutterBench]: /ai/flutter-bench


Since this page doesn't exist yet, consider dropping the cross-link or leave a basic index page in its place saying coming soon, linking to the GitHub, or linking to this page.

parlough · 2026-08-27T20:16:31Z

+        to render rich vector animations within the application.
+    - id: 57
+      name: use-shaders-animate-things-app
+      task: Implement FragmentShaders using GLSL shader programs to render custom


Since there's no exact type FragmentShaders, consider changing this to "fragment shaders":

Suggested change

task: Implement FragmentShaders using GLSL shader programs to render custom

task: Implement fragment shaders using GLSL shader programs to render custom

If you do want to refer to the type, you could say "FragmentShader objects":

task: Implement FragmentShader objects using GLSL shader programs to render custom

parlough · 2026-08-27T20:27:19Z

@@ -0,0 +1,1040 @@
+- id: 0


Are these IDs going to be stable? Like if this task is removed, a new one won't take this ID? They're used for the links to the cards, so I wanted to be sure.

parlough · 2026-08-27T20:28:37Z

+        div(classes: 'cuj-feedback', [
+          Button(
+            href: _feedbackUrl,
+            content: 'Feedback',


Consider changing this to "Provide feedback" to be action oriented.

Suggested change

content: 'Feedback',

content: 'Provide feedback',

parlough · 2026-08-27T20:28:47Z

+            href: _feedbackUrl,
+            content: 'Feedback',
+            style: ButtonStyle.outlined,
+            title: 'Leave feedback or suggest new CUJs',


Suggested change

title: 'Leave feedback or suggest new CUJs',

title: 'Leave feedback or suggest new CUJs.',

parlough · 2026-08-27T20:32:33Z

Is this coming from elsewhere or is this the source of truth?

If it's coming from elsewhere, please add a comment to the top indicating from where or how its generated.

If this is the source of truth, add a comment explaining the expected structure. https://github.com/flutter/website/blob/main/sites/www/content/blog/authors.yaml is a basic example.

parlough · 2026-08-27T20:33:28Z

+    .expand-button {
+      &:hover,
+      &:focus-within {
+        transition: transform $transition-normal;
+      }
+    }


No need to conditionally apply the transition. It'll only apply when transitioning.

Suggested change

.expand-button {

&:hover,

&:focus-within {

transition: transform $transition-normal;

}

}

.expand-button {

transition: transform $transition-normal;

@media (prefers-reduced-motion: reduce) {

transition: none;

}

}

ericwindmill added 3 commits August 20, 2026 12:02

refactor: generalize filterable index layout and components

33ddc5b

Extract generic two-column filterable index layout styles and sidebar/search components from learning resources into reusable filterable_index.dart and _filterable-index.scss.

cleaup

ebee399

feat(docs): add Critical User Journeys (CUJ) catalog and index page

fe9e250

Adds the canonical Critical User Journeys (CUJs) data, data model, filterable index page components, and styling for /ai/flutter-bench/cujs.

parlough and others added 12 commits August 26, 2026 13:31

Merge remote-tracking branch 'origin/main' into cuj-index

022086e

# Conflicts: # sites/docs/lib/_sass/components/_filterable-index.scss # sites/docs/lib/src/components/pages/filterable_index.dart # sites/docs/lib/src/components/pages/learning_resource_filters_sidebar.dart

Use 2026 license headers

5362d74

Group cuj-specific components

406ca7b

Apply cleanup similar to learning resources index

bfead4c

Misc clean up and basic API docs

6eba012

Standardize various tags, pills, and chips

a8956d2

Merge branch 'main' into feat/consolidated-tags

6266e09

Merge branch 'main' of https://github.com/flutter/website into cuj-index

10e4baf

Merge commit 'refs/pull/13804/head' of https://github.com/flutter/web…

761d026

…site into cuj-index

Merge branch 'main' of https://github.com/flutter/website into cuj-index

eedb3a7

use Tag class

bf666ec

remove unneeded file

b831c6d

ericwindmill marked this pull request as ready for review August 26, 2026 18:06

ericwindmill requested review from a team and sfshaza2 as code owners August 26, 2026 18:06

gemini-code-assist Bot reviewed Aug 26, 2026

View reviewed changes

Update sites/docs/lib/src/components/pages/cuj/cuj_filters.dart

51289ee

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

ericwindmill mentioned this pull request Aug 26, 2026

Flutter Bench content #13691

Draft

4 tasks

Update sites/docs/lib/src/components/pages/cuj/cuj_filters_sidebar.dart

b4619e5

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

lamek self-requested a review August 26, 2026 19:35

lamek approved these changes Aug 26, 2026

View reviewed changes

sfshaza2 reviewed Aug 26, 2026

View reviewed changes

parlough reviewed Aug 27, 2026

View reviewed changes


		[FlutterBench]: /ai/flutter-bench

		[critical user journey]: https://static.googleusercontent.com/media/sre.google/en//static/pdf/art-of-slos-handbook-a4.pdf

	task: Implement FragmentShaders using GLSL shader programs to render custom
	task: Implement fragment shaders using GLSL shader programs to render custom

	title: 'Leave feedback or suggest new CUJs',
	title: 'Leave feedback or suggest new CUJs.',

Uh oh!

Conversation

ericwindmill commented Aug 20, 2026 • edited by parlough Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-website-bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-website-bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lamek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfshaza2 left a comment

Choose a reason for hiding this comment

Uh oh!

ericwindmill commented Aug 27, 2026

Uh oh!

parlough left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ericwindmill commented Aug 20, 2026 •

edited by parlough

Loading

flutter-website-bot commented Aug 20, 2026 •

edited

Loading

flutter-website-bot commented Aug 20, 2026 •

edited

Loading