Skip to content

Add swipedown exit fullscreen feature - #930

Open
Ortes wants to merge 3 commits into
fluttercommunity:masterfrom
Ortes:feat/swipe-down-exit-fullscreen
Open

Add swipedown exit fullscreen feature#930
Ortes wants to merge 3 commits into
fluttercommunity:masterfrom
Ortes:feat/swipe-down-exit-fullscreen

Conversation

@Ortes

@Ortes Ortes commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.20%. Comparing base (7a4631c) to head (a56c7f0).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/chewie_player.dart 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   51.21%   51.20%   -0.02%     
==========================================
  Files          25       25              
  Lines        1728     1744      +16     
==========================================
+ Hits          885      893       +8     
- Misses        843      851       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegotori

Copy link
Copy Markdown
Collaborator

Two things:

  1. You need to make this configurable from the ChewieConttoller. In other words, you need to make this opt-in.
  2. When making this configurable, you also need to make the threshold dismissing on swipe a configurable value, defaulting to a reasonable value.

@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch 2 times, most recently from cd41237 to 0974735 Compare September 22, 2025 10:28
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from 0974735 to a56c7f0 Compare August 12, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants