Support force delete propagation policy#1227
Open
martinohansen wants to merge 2 commits into
Open
Conversation
Signed-off-by: Martin Hansen <dontbeevilpls@gmail.com> Assisted-by: Codex/GPT-5
Author
|
Fixes #603 |
Signed-off-by: Martin Hansen <dontbeevilpls@gmail.com> Assisted-by: Codex/GPT-5
martinohansen
force-pushed
the
codex/propagation-policy
branch
from
4f1f432 to
705b8d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds support for
kustomize.toolkit.fluxcd.io/propagationPolicywhen force-applying immutable resource changes. The annotation acceptsbackgroundandorphan; when it is absent, the delete request leavesPropagationPolicyunset so the Kubernetes API server default applies.Why
Force apply previously hardcoded background deletion. This prevented users from orphaning dependents during forced replacement and also meant Flux carried its own default instead of relying on Kubernetes when no annotation was set.
Validation
KUBEBUILDER_ASSETS=... go test -run TestForceApplyDeleteOptions -count=1go test -cgit diff --checkmake test-ssawas attempted, but the full envtest suite failed in existing Kubernetes 1.36 force-apply and API migration cases unrelated to the focused propagation-policy coverage.