fix: close OCI blob reader and wrap errors consistently across controllers#2066
Open
immanuwell wants to merge 1 commit into
Open
fix: close OCI blob reader and wrap errors consistently across controllers#2066immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
…llers Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 small fixes:
selectLayer()returnsio.ReadCloserbut the caller never closes it.tar.Untarwraps it inio.NopCloserso the registry connection leaks on every reconcile. Addeddefer blob.Close().bucket_controllerandocirepository_controlleruse%sinfmt.Errorf, breakingerrors.Is/errors.As.gitrepository_controlleralready uses%wfor the same message -- making the others consistent.Typo:
reconcilation->reconciliationin a user-visible message.Reproduce the leak: run with many
OCIRepositoryresources on a short interval and watchlsof -p <pid> | grep -c socketclimb without dropping between reconciles. Related: #1867.