test(extraction): cover the fork's fm_agent work-directory exclusion - #8
Merged
Conversation
The fork's own patch — `fm_agent` in `DEFAULT_IGNORE_DIRS` — had no test. It is one line in a name set, and that set is a part of the file upstream touches often, which makes it exactly the kind of thing an upstream sync can silently drop or widen. Losing it fails nothing: the build passes, the suite is green, the release ships, and the index quietly grows a second copy of every function FM-Agent extracted. Pins the behaviour down, and records the file in FORK.md's patch table — the list a sync is checked against.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's own patch —
fm_agentinDEFAULT_IGNORE_DIRS— has no test. It is oneline in a name set, and that set sits in a file upstream touches often, which makes
it exactly the kind of thing an upstream sync can silently drop or widen. Losing it
fails nothing: the build passes, the suite is green, the release ships, and the
index quietly grows a second copy of every function FM-Agent extracted.
This adds regression cover for it, and records the file in FORK.md's patch table —
the list a sync is checked against.
What it pins
languages the artifacts come in. Depth matters: FM-Agent's work directory sits at
the root of the directory it was pointed at, which is not necessarily the root
CodeGraph indexes.
fm_agent_data/,my_fm_agent/and a file namedfm_agent.call stay indexed. This is what keepsthe blast radius small.
.gitignorenegation (!fm_agent/) takes the directory back, nested included.That escape hatch is what makes the any-depth match acceptable, so it belongs in a
test rather than only in prose.
the artifacts committed. The second case is not hypothetical — FM-Agent's
incremental mode checks a commit that can contain them out into a temporary
worktree and indexes that.
Verification
New tests 4/4; full suite 2905 passed, 0 failed.
Mutation-checked: commenting out the one line in
DEFAULT_IGNORE_DIRSfails 3 of the4 (the fourth asserts a directory is indexed, which holds without the patch too —
as expected).