Skip to content

MDEXP-921: “Failed“ column is empty when export using Default linked data export job profile completes with errors or fails with not found records#698

Merged
PBobylev merged 3 commits into
masterfrom
MDEXP-921
May 11, 2026
Merged

MDEXP-921: “Failed“ column is empty when export using Default linked data export job profile completes with errors or fails with not found records#698
PBobylev merged 3 commits into
masterfrom
MDEXP-921

Conversation

@zepheiryan
Copy link
Copy Markdown
Contributor

@zepheiryan zepheiryan commented May 7, 2026

https://folio-org.atlassian.net/browse/MDEXP-921

Purpose

Correct the failed record count for jobs with invalid IDs.

Approach

In addition to existing code for saving the not found ID set in export statistics, also update the statistics failure count.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?

    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?

    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@zepheiryan zepheiryan marked this pull request as ready for review May 7, 2026 19:28
@PBobylev PBobylev merged commit 2df45a0 into master May 11, 2026
16 checks passed
@PBobylev PBobylev deleted the MDEXP-921 branch May 11, 2026 08:36
PBobylev pushed a commit that referenced this pull request May 12, 2026
…data export job profile completes with errors or fails with not found records (#698)

* Amend failed count to account for IDs not found in results

* Update changelog

* Update test with correct failed count

(cherry picked from commit 2df45a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants