Rename branching_scheme* to tree_search* and add tree_search() functions#386
Open
fontanf wants to merge 1 commit into
Open
Rename branching_scheme* to tree_search* and add tree_search() functions#386fontanf wants to merge 1 commit into
fontanf wants to merge 1 commit into
Conversation
Each module's branching_scheme.{hpp,cpp} is renamed to tree_search.{hpp,cpp}
and gains a tree_search() function (with TreeSearchOutput/TreeSearchParameters
structs) following the same pattern as rectangleguillotine/column_generation_2.
The optimize_tree_search helper that previously lived in each optimize.cpp
anonymous namespace is eliminated; optimize.cpp now calls tree_search() directly.
For box, branching_scheme_maximal_spaces.* becomes tree_search_maximal_spaces.*
with a tree_search_maximal_spaces() function.
fontanf
force-pushed
the
refactor/tree-search
branch
from
7b6fc6a to
34873ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each module's branching_scheme.{hpp,cpp} is renamed to tree_search.{hpp,cpp} and gains a tree_search() function (with TreeSearchOutput/TreeSearchParameters structs) following the same pattern as rectangleguillotine/column_generation_2. The optimize_tree_search helper that previously lived in each optimize.cpp anonymous namespace is eliminated; optimize.cpp now calls tree_search() directly.
For box, branching_scheme_maximal_spaces.* becomes tree_search_maximal_spaces.* with a tree_search_maximal_spaces() function.