fix: filter excludedFields from expandedOriginalQueryFields#1207
Open
alanjaouen wants to merge 1 commit into
Open
fix: filter excludedFields from expandedOriginalQueryFields#1207alanjaouen wants to merge 1 commit into
alanjaouen wants to merge 1 commit into
Conversation
Fields listed in `excludedFields` were correctly removed from the SOQL query but still appeared as columns in output CSV files. Root cause: `expandedOriginalQueryFields` combined `_originalFieldsInQuery` (filtered) with `_resolveMultiselectFieldNames` (unfiltered). When using `SELECT all`, all fields come from the multiselect resolver, bypassing the exclusion entirely. Move the excluded-field filter to after all field sources are merged so it covers both `_originalFieldsInQuery` and multiselect-resolved fields. Closes forcedotcom#1206
alanjaouen
force-pushed
the
fix/excluded-fields-csv-columns
branch
from
8e62a1e to
7e503dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields listed in
excludedFieldswere correctly removed from the SOQL query but still appeared as columns in output CSV files.Root cause:
expandedOriginalQueryFieldscombined_originalFieldsInQuery(filtered early) with_resolveMultiselectFieldNames(unfiltered). When usingSELECT all, all fields come from the multiselect resolver, so the per-field exclusion check was entirely bypassed.Fix: Move the
excludedFieldsfilter to after all field sources are merged, so it covers both_originalFieldsInQueryand multiselect-resolved fields.Closes #1206