Skip to content

Update SalesforceSDKCoreTestApp to use scene lifecycle #4076

Merged
bbirman merged 1 commit into
forcedotcom:devfrom
bbirman:app-scene
Jun 23, 2026
Merged

Update SalesforceSDKCoreTestApp to use scene lifecycle #4076
bbirman merged 1 commit into
forcedotcom:devfrom
bbirman:app-scene

Conversation

@bbirman

@bbirman bbirman commented Jun 19, 2026

Copy link
Copy Markdown
Member

Modernize to avoid this warning in the logs:
"UIScene lifecycle will soon be required. Failure to adopt will result in an assert in the future."

@bbirman

bbirman commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Updated to use the same structure as the common test app. If this sounds good I'll do the same thing to the test apps for analytics, mobile sync and smart store

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
TestsPassedSkippedFailed ❌️
AuthFlowTester UI Test Results all1 ran1 ❌
TestResult
AuthFlowTester UI Test Results all
AuthFlowTesterUITests.xctest
LegacyLoginTests.testCAOpaque_DefaultScopes_WebServerFlow()❌ failure

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (4d7e758) to head (e450fff).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4076      +/-   ##
==========================================
- Coverage   70.99%   66.66%   -4.34%     
==========================================
  Files         246      246              
  Lines       21501    21501              
==========================================
- Hits        15265    14334     -931     
- Misses       6236     7167     +931     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.79% <ø> (-0.19%) ⬇️
Core 59.29% <ø> (-6.67%) ⬇️
SmartStore 73.44% <ø> (-0.16%) ⬇️
MobileSync 88.79% <ø> (-0.03%) ⬇️
see 40 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wmathurin wmathurin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions

Copy link
Copy Markdown
1 Warning
⚠️ Big PR, try to keep changes smaller if you can.

Generated by 🚫 Danger

@bbirman bbirman changed the title Update SalesforceSDKCoreTestApp to use scene lifecycle Update test apps to use scene lifecycle Jun 22, 2026
@bbirman bbirman marked this pull request as ready for review June 22, 2026 18:19
@github-actions

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SalesforceAnalytics iOS ^18 Test Results19 ran19 ✅
TestResult
No test annotations available

@github-actions

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SmartStore iOS ^18 Test Results177 ran177 ✅
TestResult
No test annotations available

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SalesforceAnalytics iOS ^26 Test Results19 ran19 ✅
TestResult
No test annotations available

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SmartStore iOS ^26 Test Results177 ran177 ✅
TestResult
No test annotations available

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^18 Test Results652 ran652 ✅
TestResult
No test annotations available

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
TestsPassed ☑️SkippedFailed ❌️
MobileSync iOS ^26 Test Results234 ran227 ✅7 ❌
TestResult
MobileSync iOS ^26 Test Results
BriefcaseSyncDownTests.testCleanGhostsOneObjectType()❌ failure
BriefcaseSyncDownTests.testCleanGhostsTwoObjectTypes()❌ failure
BriefcaseSyncDownTests.testIdsToSkip()❌ failure
BriefcaseSyncDownTests.testStartFetchWithMaxTimestamp()❌ failure
BriefcaseSyncDownTests.testStartFetchWithoutMaxTimestamp()❌ failure
BriefcaseSyncDownTests.testSyncDownFetchingTwoObjectTypes()❌ failure
BriefcaseSyncDownTests.testSyncDownFetchingTwoObjectTypesMultipleRetrieveCalls()❌ failure

@github-actions

Copy link
Copy Markdown
TestsPassed ☑️SkippedFailed ❌️
MobileSync iOS ^18 Test Results234 ran233 ✅1 ❌
TestResult
MobileSync iOS ^18 Test Results
SyncManagerTests.testCleanResyncGhostsForMRUTarget❌ failure

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^26 Test Results652 ran652 ✅
TestResult
No test annotations available

@bbirman bbirman force-pushed the app-scene branch 2 times, most recently from d2e5da7 to 8a71bad Compare June 23, 2026 03:58
@bbirman bbirman changed the title Update test apps to use scene lifecycle Update SalesforceSDKCoreTestApp to use scene lifecycle Jun 23, 2026
@bbirman

bbirman commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Will update the other test apps in other PRs to avoid having a large PR

@bbirman bbirman merged commit d3fbf59 into forcedotcom:dev Jun 23, 2026
39 of 50 checks passed
@bbirman bbirman deleted the app-scene branch June 23, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants