Repository navigation
generate lineage - #160
Open
joroscoSF wants to merge 5 commits into
Open
generate lineage#160joroscoSF wants to merge 5 commits into
joroscoSF wants to merge 5 commits into
Conversation
markdlv-sf
reviewed
Oct 12, 2026
| for client in (*saved_clients, *_BaseClient._live_instances): | ||
| if client is not None: | ||
| session.wrap(client) | ||
| _BaseClient.__new__ = staticmethod(capturing_new) # type: ignore[assignment] |
Contributor
There was a problem hiding this comment.
Would it be possible to utilize reader_config/writer_config with force instead of hooking into __new__?
markdlv-sf
reviewed
Oct 12, 2026
| # Every client built in this process, including ones no longer the | ||
| # singleton that a module still holds a reference to (lineage capture must | ||
| # reach those too) | ||
| _live_instances: ClassVar[weakref.WeakSet[_BaseClient]] = weakref.WeakSet() |
Contributor
There was a problem hiding this comment.
Could we have generate_lineage run in a subprocess? I think that'd avoid the need for this weakref set, the saved and restored singletons, the nested-capture guard, and the restore logic.
markdlv-sf
reviewed
Oct 12, 2026
|
|
||
| Only the columns that feed a column's *value* are sources. Filter predicates, | ||
| join conditions and sort keys gate or order rows and are deliberately ignored. | ||
| """ |
Contributor
There was a problem hiding this comment.
This is a lot of code- can we explore integrating with something like OpenLineage to take care of this part for us?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.