Repository navigation
Fix declaration order in external BLAS/LAPACK interfaces - #1221
Open
Chaitanya-970 wants to merge 3 commits into
Open
Chaitanya-970 wants to merge 3 commits into
Chaitanya-970 wants to merge 3 commits into
Conversation
Chaitanya-970
marked this pull request as draft
October 15, 2026 18:00
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 69.52% 69.44% -0.08%
==========================================
Files 20 20
Lines 2556 2556
==========================================
- Hits 1777 1775 -2
- Misses 779 781 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Chaitanya-970
marked this pull request as ready for review
October 16, 2026 09:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1210.
With external BLAS/LAPACK enabled, gfortran rejects some interfaces under
-std=f2018because arrays are declared before the integer arguments used in their bounds. This moves those integer declarations ahead of the arrays without changing the procedure signatures.CI now includes a GCC 14 Release build with external BLAS/LAPACK, followed by a separate
-std=f2018compilation check of the external interface modules. Library discovery is required so the job cannot silently fall back to the bundled implementation.This also fixes the bare
dlentry in the generated pkg-config file, which was preventing Linux CI from linking its smoke test. The same issue is covered by #1220.Tested with gfortran 15.3.1:
-std=f2018, as do the isolated 64-bit external interface declarations.The external suite was run serially after a parallel run hit shared-file interference in the
loadtxtexample. The separate GCC 15 compatibility problems covered by #1209 are outside this change.