Prevent mutation of shared excluded_files list

[bjk7119]

Summary by CodeRabbit

• Bug Fixes

  • Improved file exclusion tracking during source code scanning to separately handle binary file exclusions, ensuring more accurate exclusion patterns and reducing potential scanning errors.

• Chores

  • Enhanced debug logging for file exclusion operations to aid in troubleshooting scan behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d9fc7ff9-c4ad-43fb-9fe2-9548ff0a88eb

📥 Commits

Reviewing files that changed from the base of the PR and between 62f153e and e5f559b.

📒 Files selected for processing (1)

• src/fosslight_source/run_scancode.py

---

📝 Walkthrough

Walkthrough

The run_scan function's directory scanning exclusion logic now separates binary exclusion tracking from other file exclusions. A dedicated binary_files_to_exclude list is initialized before scanning and collects excluded binaries during traversal, then combined with existing excluded files into the final ignore patterns.

Changes

Binary exclusion tracking refactor

Layer / File(s)	Summary
Separate binary exclusion tracking src/fosslight_source/run_scancode.py	Initialize binary_files_to_exclude list before scanning, append excluded binaries into that separate list (replacing previous reuse of excluded_files), and combine both lists into total_files_to_excluded ignore patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fosslight/fosslight_source_scanner#265: Updates binary exclusion handling in run_scan to separate binary file exclusion tracking from other exclusion types.

Suggested labels

chore

Suggested reviewers

• dd-jy

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: preventing mutation of a shared excluded_files list, which aligns with the summary showing that binary file exclusions are now tracked separately to avoid modifying the original excluded_files list.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch excludebin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}