Fix issues around fioctl_version#935
Merged
kprosise merged 1 commit intofoundriesio:nextfrom May 5, 2026
Merged
Conversation
angolini
reviewed
Apr 30, 2026
| run: | | ||
| export fv=$(wget -q -O- https://api.github.com/repos/foundriesio/fioctl/releases/latest | grep tag_name | sed -E 's/.*"([^"]+)".*/\1/') | ||
| echo "fv=$fv" >> "$GITHUB_ENV" | ||
| wget -O /tmp/fioctl https://github.com/foundriesio/fioctl/releases/download/${fv}/fioctl-linux-amd64 |
Collaborator
There was a problem hiding this comment.
the URL is wrong, use https://github.com/foundriesio/fioctl/releases/download/latest/fioctl-linux-amd64
go back to the message I sent in slack because the curl command did not worked for me either
Contributor
Author
There was a problem hiding this comment.
I'll address both uses in a push early next week
Contributor
Author
There was a problem hiding this comment.
Ah, so the URL is conditionally wrong...where fv==latest. When fv is an actual version, things flip....meaning either we use different URLs for each case, or just stick with using latest, which was already preposed anyway.
Fixes included adding an `export` to the fioctl install steps, updating the download URL, and switching to always using the latest. This commit addresses issue FFTK-4779, "fix fioctl version…" Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
kprosise
force-pushed
the
add-fioctl_version-case
branch
from
4bd1ace to
d4de8a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes included adding an
exportto the fioctl install steps, adding the fioctl version to the GitHub envars in the workflow files so that it is available for the doc builds, and adding a case where it isn't passed to default tolatest.This commit addresses issue FFTK-4779, "fix fioctl version…"
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness