Skip to content

fix: show binary stderr on version check failure - #123

Merged
onbjerg merged 1 commit into
masterfrom
fig/show-binary-stderr
Sep 2, 2026
Merged

onbjerg merged 1 commit into
masterfrom
fig/show-binary-stderr

Conversation

@figtracer

@figtracer figtracer commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • include captured stderr when a downloaded binary fails its -V check
  • preserve the existing status-only error when the child process emits no diagnostic
  • cover loader errors with a regression test based on the macOS libusb failure

Context

The Foundry v1.8.1 Intel macOS binary aborts when its linked libusb dylib is unavailable. Command::output captured the useful dyld diagnostic, but get_bin_version discarded stderr and reported only SIGABRT, hiding the actionable cause.

@figtracer
figtracer marked this pull request as ready for review September 1, 2026 07:59
@onbjerg
onbjerg merged commit b4eaebe into master Sep 2, 2026
12 checks passed
@onbjerg
onbjerg deleted the fig/show-binary-stderr branch September 2, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants