fix: back off transient download retries - #125
Merged
Merged
Conversation
The reqwest retry policy retries immediately, which can exhaust attempts before a temporary GitHub outage recovers. Space GitHub GET and HEAD retries with capped exponential delays while preserving the configured retry count and HTTP status classification.
figtracer
marked this pull request as ready for review
September 10, 2026 10:46
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
September 10, 2026 10:46
mablr
reviewed
Sep 10, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
Makes sense, just style concern.
figtracer
enabled auto-merge (squash)
September 10, 2026 11:06
mablr
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient GitHub 502 can exhaust every download attempt because reqwest’s retry policy retries immediately; it does not implement the backoff described in the existing comment. Send GitHub GET and HEAD requests through an explicit retry loop with 1, 2, 4, 8, and 16 second delays, capped at 16 seconds for larger retry counts. Preserve
FOUNDRYUP_MAX_RETRIES, the existing status classification and host scope, and attestation verification. Response-body failures remain outside this retry loop.Full integration and live-install verification remain blocked by the installer’s existing running-forge guard on this machine.
AI assistance: implemented with OpenAI Codex.