You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Promote _pose_estimator._get_model_path to a public helper #360
_posetools.extract_pose_landmarks reuses the MediaPipe model download/cache via the private _pose_estimator._get_model_path() (TODO already in code, added during #353 review). Promote it to a small public helper so cross-module use isn't coupled to a private name. Related: revisit the Solutions-vs-Tasks API preference (use_solutions = hasattr(mp, 'solutions')) once the legacy family is fully retired — also marked in-code.
Done in 744169f: _get_model_path is promoted to a module-level public helper, musicalgestures.get_pose_model_path(model_complexity=1, models_dir=None) in _pose_estimator.py, exported from the package root. extract_pose_landmarks now calls it instead of the private method, MediaPipePoseEstimator._get_model_path delegates to it, and the model URLs/names live in module-level constants (the class attributes remain as aliases). Covered by a regression test (test_get_pose_model_path_cache) that checks download-once caching and the invalid-complexity fallback.
The second point (dropping the Solutions-API preference once legacy mediapipe wheels are fully retired) remains marked in-code in _posetools.py and is out of scope here.
Activity
Fix five known bugs; public pose-model helper (#360); windowed pose e…
alexarje commentedon Aug 6, 2026
Done in 744169f:
_get_model_pathis promoted to a module-level public helper,musicalgestures.get_pose_model_path(model_complexity=1, models_dir=None)in_pose_estimator.py, exported from the package root.extract_pose_landmarksnow calls it instead of the private method,MediaPipePoseEstimator._get_model_pathdelegates to it, and the model URLs/names live in module-level constants (the class attributes remain as aliases). Covered by a regression test (test_get_pose_model_path_cache) that checks download-once caching and the invalid-complexity fallback.The second point (dropping the Solutions-API preference once legacy mediapipe wheels are fully retired) remains marked in-code in
_posetools.pyand is out of scope here.