Skip to content

Improve more NTDS attributes#55

Merged
Schamper merged 3 commits into
mainfrom
ntds-more-attrs
May 5, 2026
Merged

Improve more NTDS attributes#55
Schamper merged 3 commits into
mainfrom
ntds-more-attrs

Conversation

@Schamper
Copy link
Copy Markdown
Member

  • Add more typed attributes
  • Move some attribute decoding from "global" decoding to class specific
    • The benefit of this is so that we don't fill up ATTRIBUTE_ENCODE_DECODE_MAP with every attribute that requires some additional type tweaking, but keep that logic separated with the classes. The reason for doing additional decoding this way and not in a specific @property def attr_name is so that we also get the better type with .get() and .as_dict().
  • Tweak system flags a bit
  • Add additional helper methods to NTDS for retrieving certain objects

@Schamper Schamper requested a review from joost-j April 17, 2026 16:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (d25481c) to head (0445898).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/database/ese/ntds/util.py 0.00% 70 Missing ⚠️
dissect/database/ese/ntds/objects/user.py 0.00% 37 Missing ⚠️
dissect/database/ese/ntds/objects/trusteddomain.py 0.00% 18 Missing ⚠️
dissect/database/ese/ntds/objects/object.py 0.00% 17 Missing ⚠️
...ct/database/ese/ntds/objects/organizationalunit.py 0.00% 15 Missing ⚠️
.../database/ese/ntds/objects/organizationalperson.py 0.00% 10 Missing ⚠️
dissect/database/ese/ntds/objects/computer.py 0.00% 9 Missing ⚠️
dissect/database/ese/ntds/objects/site.py 0.00% 9 Missing ⚠️
dissect/database/ese/ntds/ntds.py 0.00% 7 Missing ⚠️
dissect/database/ese/ntds/database.py 0.00% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #55    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        151     151            
  Lines       4325    4537   +212     
======================================
- Misses      4325    4537   +212     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing ntds-more-attrs (0445898) with main (d25481c)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@joost-j joost-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement! Other than some minor return type suggestions, no comments.

Comment thread dissect/database/ese/ntds/objects/group.py Outdated
Comment thread dissect/database/ese/ntds/objects/configuration.py Outdated
Comment thread dissect/database/ese/ntds/objects/organizationalunit.py Outdated
Comment thread dissect/database/ese/ntds/objects/organizationalunit.py Outdated
Comment thread dissect/database/ese/ntds/objects/organizationalunit.py Outdated
Comment thread dissect/database/ese/ntds/objects/user.py Outdated
@Schamper Schamper force-pushed the ntds-more-attrs branch from c0e17da to 0925347 Compare May 5, 2026 08:30
@Schamper Schamper requested a review from joost-j May 5, 2026 08:34
@Schamper Schamper force-pushed the ntds-more-attrs branch from 3bc002d to 0445898 Compare May 5, 2026 08:44
@Schamper Schamper merged commit b66c61d into main May 5, 2026
19 checks passed
@Schamper Schamper deleted the ntds-more-attrs branch May 5, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants