Skip to content

Nh2 fix streaming process on nonthreaded - #45

Open
snoyberg wants to merge 1 commit into
masterfrom
nh2-fix-streamingProcess-on-nonthreaded
Open

Nh2 fix streaming process on nonthreaded#45
snoyberg wants to merge 1 commit into
masterfrom
nh2-fix-streamingProcess-on-nonthreaded

Conversation

@snoyberg

Copy link
Copy Markdown
Contributor

No description provided.

@snoyberg
snoyberg force-pushed the nh2-fix-streamingProcess-on-nonthreaded branch 3 times, most recently from b333a4a to b4e93a9 Compare January 19, 2018 09:10
@snoyberg
snoyberg force-pushed the nh2-fix-streamingProcess-on-nonthreaded branch from b4e93a9 to e88369a Compare January 31, 2018 15:13
@snoyberg

snoyberg commented Jul 3, 2018

Copy link
Copy Markdown
Contributor Author

Just discussed, due to close_fds this approach can't work.

@snoyberg snoyberg closed this Jul 3, 2018
@snoyberg
snoyberg deleted the nh2-fix-streamingProcess-on-nonthreaded branch July 3, 2018 08:57
@snoyberg
snoyberg restored the nh2-fix-streamingProcess-on-nonthreaded branch July 3, 2018 08:59
@snoyberg

snoyberg commented Jul 3, 2018

Copy link
Copy Markdown
Contributor Author

Closed prematurely...

@snoyberg snoyberg reopened this Jul 3, 2018
@snoyberg

snoyberg commented Jul 3, 2018

Copy link
Copy Markdown
Contributor Author

Pinging @nh2, as we discussed, this won't work in a case where close_fds is set, since the process package's C code will close the pipe before the child process is execd.

@Profpatsch

Copy link
Copy Markdown

I just ran into this, ping @nh2

@nh2

nh2 commented Jun 29, 2022

Copy link
Copy Markdown
Member

I am not sure I will have time to look into this in detail currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants