Skip to content

Link libatomic where 64-bit atomics are not native, fixing the piwheels build #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpedd merged 2 commits into from
Sep 3, 2026
+14 −0
Merged

Link libatomic where 64-bit atomics are not native, fixing the piwheels build #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56dd9e4
Link libatomic where 64-bit atomics are not native, fixing the piwhee…
fpedd Sep 2, 2026
eb82591
Drop the redundant libatomic probe and shrink the atomics check
fpedd Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,20 @@ nanobind_add_module(
target_include_directories(_cpp PRIVATE src/cpp)
target_link_libraries(_cpp PRIVATE Threads::Threads)

# 64-bit atomics compile to libatomic calls where the target has no native
# double-word atomics (32-bit ARM as Raspberry Pi OS builds it); the module then
# links but fails to load with an undefined __atomic_*_8 symbol.
include(CheckCXXSourceCompiles)
check_cxx_source_compiles(
"#include <atomic>
#include <cstdint>
std::atomic<std::int64_t> value;
int main() { return static_cast<int>(value.fetch_add(1)); }"
HAVE_NATIVE_INT64_ATOMICS)
if(NOT HAVE_NATIVE_INT64_ATOMICS)
target_link_libraries(_cpp PRIVATE atomic)
endif()

option(WARNINGS_AS_ERRORS "Treat compiler warnings as errors" OFF)

if(MSVC)
Expand Down
Loading