Skip to content

fix(ci): fix GNU sed syntax in Pdoc workflow and add manual trigger - #341

Open
245678000000 wants to merge 1 commit into
freelawproject:mainfrom
245678000000:fix-pdoc-sed-syntax
Open

fix(ci): fix GNU sed syntax in Pdoc workflow and add manual trigger#341
245678000000 wants to merge 1 commit into
freelawproject:mainfrom
245678000000:fix-pdoc-sed-syntax

Conversation

@245678000000

Copy link
Copy Markdown

Fixes

Fixes: #316

Summary

The Pdoc workflow (.github/workflows/pdoc.yml) runs on ubuntu-latest (GNU sed), where sed -i '' causes sed to treat '' as an empty script and the following regex argument as a target filename, resulting in sed: can't read ...: No such file or directory.

This PR:

  1. Removes the macOS-specific '' argument from sed -i so it executes properly under GNU sed.
  2. Adds a workflow_dispatch: trigger to allow manually re-running the docs build workflow from GitHub Actions without re-pushing/moving release tags.
  3. Updates CHANGES.md.

AI Disclosure

  • No AI tools were used to create the content of this PR.
  • Parts of this PR were created with the help of an AI tool, and I have carefully reviewed all of its content and take full responsibility for it.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

- v*.*.*
tags:
- v*.*.*
workflow_dispatch:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this?

@mlissner

Copy link
Copy Markdown
Member

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pdoc workflow fails on Run sed step (BSD vs GNU sed -i syntax)

2 participants