Fix Windows action script path#23
Open
llucax wants to merge 1 commit into
Open
Conversation
On Windows, `github.action_path` expands to a path with backslashes. Interpolating it directly into a bash `run` step makes bash consume those backslashes while parsing the generated script, producing an invalid path. Use `$GITHUB_ACTION_PATH` so the path is expanded from the environment at runtime, after bash has tokenized the wrapper script. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
Bot
added
part:tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
github.action_pathexpands to a path with backslashes. Interpolating it directly into a bashrunstep makes bash consume those backslashes while parsing the generated script, producing an invalid path.Use
$GITHUB_ACTION_PATHso the path is expanded from the environment at runtime, after bash has tokenized the wrapper script.Fixes #22.