fix(cors): allow PATCH in restricted policy - #1371
Open
CattonNyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shipped restricted CORS configuration allows
GET,POST,PUT, andDELETE, but does not allowPATCH.The API already exposes PATCH endpoints for product prices, product stock, file visibility, and user status, and both React clients call these endpoints. When the frontend and API use different origins with
CorsOptions.AllowAll=false, the browser rejects the PATCH preflight before the request reaches the API.This is hidden during local development because
appsettings.Development.jsonsetsAllowAll=true, which usesAllowAnyMethod().Fix
PATCHtoCorsOptions.AllowedMethodsinappsettings.json.PATCHto the production configuration as well.PATCH.src/BuildingBlocksarea.Verification
dotnet test src/Tests/Framework.Tests/Framework.Tests.csproj -c Releasedotnet build src/FSH.Starter.slnx -c Release --no-restore -warnaserror -p:NuGetAudit=false -m:1SSH.NETadvisory in the integration test projects.Fixes #1370