Skip to content

feat(gateway): guard the resolver properties that published sites now rely on #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsan6sha merged 1 commit into from
Sep 12, 2026
Merged

feat(gateway): guard the resolver properties that published sites now rely on #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified cloudflare/ipns-resolver-worker.test.mjs
View file
Open in desktop
Binary file not shown.
17 changes: 11 additions & 6 deletions lib/core/services/ipfs_gateway_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,17 @@ class IpfsGatewayHelper {
/// returned 200 from Filebase for the same CID at the same moment.
static const String filebaseTemplate = 'https://ipfs.filebase.io/ipfs/';

/// fx's own gateway. This was the pre-v0.4 default, and [init] used to
/// migrate people AWAY from it and onto dweb — that migration is gone,
/// because the destination is now the thing that is dying. It is offered as
/// a first-class preset again: it serves these CIDs with correct content
/// types (verified 2026-09-12) and, unlike any third party, it is ours.
/// fx's own gateway.
///
/// NOT offered in the picker: it serves an interstitial "content withheld"
/// page before HTML (measured 2026-09-12 in a browser — curl bypasses it),
/// which is a poor thing to put in front of someone opening a shared
/// website, and is almost certainly why it stopped being the default.
///
/// It remains useful, and is kept, because raw ASSETS are served normally
/// (correct `image/jpeg`, no interstitial): it is the second entry in the
/// published fallback chain, so a site is never at the mercy of one third
/// party. Also still accepted as a `?gw=fx` key on the resolver.
static const String fxTemplate = 'https://ipfs.cloud.fx.land/gateway/';

static const String defaultTemplate = filebaseTemplate;
Expand All @@ -46,7 +52,6 @@ class IpfsGatewayHelper {
/// a gateway that [init] would migrate away from on next launch is a trap.
static const Map<String, String> presets = <String, String>{
'Filebase': filebaseTemplate,
'fx.land': fxTemplate,
};

/// Preset label for [template], or null when it is a custom value.
Expand Down
12 changes: 10 additions & 2 deletions test/unit/core/services/ipfs_gateway_helper_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,21 @@ void main() {
test('names the presets and nothing else', () {
expect(IpfsGatewayHelper.presetLabelFor(IpfsGatewayHelper.filebaseTemplate),
'Filebase');
expect(IpfsGatewayHelper.presetLabelFor(IpfsGatewayHelper.fxTemplate),
'fx.land');
expect(IpfsGatewayHelper.presetLabelFor('https://my-host/ipfs/'), isNull);
expect(IpfsGatewayHelper.presetLabelFor(IpfsGatewayHelper.dwebTemplate),
isNull);
});

// fx serves an interstitial before HTML, so it is a poor thing to put in
// front of a shared website — but it serves raw assets fine and stays in
// the published fallback chain and as a resolver key.
test('fx is NOT offered in the picker but is still a resolver key', () {
expect(IpfsGatewayHelper.presets.values,
isNot(contains(IpfsGatewayHelper.fxTemplate)));
expect(IpfsGatewayHelper.frontDoorGatewayKey(IpfsGatewayHelper.fxTemplate),
'fx');
});

test('tolerates surrounding whitespace', () {
expect(
IpfsGatewayHelper.presetLabelFor(
Expand Down
Loading