Repository navigation
Prepare for removal of S4 classes standardGeneric and nonstandardGeneric - #16
Merged
Merged
Conversation
Collaborator
|
Thanks for this. I'll fix. I've got the exact same code in progressify (https://github.com/search?q=repo%3Afutureverse%2Fprogressify+language%3Ar+standardGeneric&type=code) - I'll make sure to fix there too |
Contributor
Author
|
Great, thanks. Then I won't bother with a PR for progressify. |
HenrikBengtsson
added a commit
that referenced
this pull request
Oct 20, 2026
HenrikBengtsson
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is planned that R 4.7.0 will prune S4 classes
standardGenericandnonstandardGenericand their subclasses, so that all new S4 generic function objects have classgenericFunctionrather than inheriting from that class indirectly. Note that the to-be-pruned S4 classes are documented as for internal use by package methods, hence not for use by any contributed package. This PR guards your package against the pending change in R by eliminating usage of the to-be-pruned S4 classes while preserving existing behaviour.