fix: honor configured start_block on cold start#107
Open
aliraghebi wants to merge 1 commit into
Open
Conversation
The start_block config field (ChainConfig.StartBlock, yaml `start_block`) was defined, validated, and documented for every chain in config.example.yaml, but never read anywhere in the codebase. On a cold start with no persisted checkpoint, RegularWorker.determineStartingBlock always anchored on the current chain head, silently discarding the configured start_block and making backfills from a chosen height impossible. Use start_block as the cold-start anchor when the block store is healthy and has no prior block. A warm start (existing KV checkpoint) still wins and resumes from the checkpoint, and a down store still falls back to the chain head so a broken store never re-triggers a backfill from start_block on every restart. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
The start_block config field (ChainConfig.StartBlock, yaml
start_block) was defined, validated, and documented for every chain in config.example.yaml, but never read anywhere in the codebase. On a cold start with no persisted checkpoint, RegularWorker.determineStartingBlock always anchored on the current chain head, silently discarding the configured start_block and making backfills from a chosen height impossible.Use start_block as the cold-start anchor when the block store is healthy and has no prior block. A warm start (existing KV checkpoint) still wins and resumes from the checkpoint, and a down store still falls back to the chain head so a broken store never re-triggers a backfill from start_block on every restart.